-
Notifications
You must be signed in to change notification settings - Fork 6
Add EMP June 2025 data release #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…n raw files pulled from EDI
…set no longer contains amphipods
| # "Americorophium_UnID Adult Macro" | ||
| # - All other Macro-missing taxa must be amphipod-related | ||
| # (any species or higher grouping within Amphipoda). | ||
| testthat::expect_true("Americorophium_UnID Adult Macro" %in% macro_missing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "Americorophium_UnID Adult Macro" treated differently from the rest of the amphipods? Wouldn't it be caught in the next test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sbashevkin! Sorry to be tardy in responding. Here is my thinking:
Americorophium isn’t treated differently/uniquely in the data itself—the test here just uses it as a quick sanity check. After EMP Macro dropped amphipods, the list of missing macro taxa can change, so the test can’t rely on an exact list. The next test only checks that anything missing is amphipod‑related, which could still pass even if no amphipod roll‑up showed up at all. Calling out Americorophium makes sure at least one expected amphipod roll‑up is actually present.
Does that make sense? You know the data better than I do, so if that's not actually the desired behavior, we can nix this.
Incorporated recently-released EMP data from EDI. Primary changes are: